Parallels / artifactory

A Python client for Artifactory
MIT License
82 stars 54 forks source link

artifactory.walk() should return child files and directories as strings #9

Closed knazarov closed 10 years ago

knazarov commented 10 years ago

@ChipJust please take a look

ChipJust commented 10 years ago

Looks good to me.

ChipJust commented 10 years ago

Do you want me to add the walkfilter function to the module (not in the class) like we did the walk?

knazarov commented 10 years ago

@ChipJust no, this function is for users to implement in their code. On the other hand, I'll need to somehow implement Artifactory-flavoured searching/filtering (as in REST API). The difficult part of this is that search is only supported by Pro version, but I'd like the search interface to work on the Free version too. So there will be two implementations: native and fast, and slow that is implemented on top of general tree walking