search

Parallels / docker-machine-parallels

Parallels driver for Docker Machine https://github.com/docker/machine
MIT License
471 stars 35 forks source link

Make --parallels-memory flag match --driver-memory-size flags #31

Closed jgeiger closed 8 years ago

jgeiger commented 8 years ago
legal90 commented 8 years ago

The default drivers use --driver-memory-size to set the default memory.

Not quite. virtualbox, hyperv and softlayer drivers use --<driver>-memory flag too, without "-size" prefix. There are no any conventions in Docker Machine about these driver options, so each driver could implement their own flags.

@jgeiger Thank you for contribution. I agree that --parallels-memory-size would be better, but we can't just rename it because it will break the backward compatibility. It is better to keep both variants working and remove the old one completely only in the next major release.

jgeiger commented 8 years ago

I added the -memory-size as a new flag, and check to see if it's defaultMemory. If not, we use it, if so it drops into using the old flag.

I've also submitted a pull request to docker-machine to standardize on using --driver-memory-size for the above mentioned drivers.

legal90 commented 8 years ago

Thanks! Let's track the discussion in your PR https://github.com/docker/machine/pull/2691. We'll follow the final decision which Docker Machine maintainers will make.

legal90 commented 8 years ago

@jgeiger I appreciate the effort you've put to this PR, but we can see that the final decision about CLI design on the Docker Machine side has been delayed.

About our case here - I think it's better just to keep the things simple and continue to support the only one expected name of memory flag - --parallels-memory. I'm looking forward these flags being standardized on the upstream's level in the future. Thank you again!