Parallels / packer-plugin-parallels

Packer plugin for Parallels Builder
https://www.packer.io/docs/builders/parallels
Mozilla Public License 2.0
13 stars 14 forks source link

Add support for configuring disk size in parallels-ipsw builder #112

Closed johnbyrneio closed 4 months ago

johnbyrneio commented 5 months ago

Adds support for specifying disk_size when using the ipsw builder.

Follows the same implementation as the iso builder, except that macOS on Apple Silicon only supports disk_type: plain, and iface: sata. For that reason, I hard-coded those values in step_create_disk.go.

Closes #111

cjlapao commented 5 months ago

@johnbyrneio this is failing on the build step, please have a look so we can merge this, thanks

cjlapao commented 4 months ago

@johnbyrneio We are still waiting for the fix in the Go Validate step before we can merge this. because this is a fork we are unable to fix it from our side. could you please have a look at this?

cjlapao commented 4 months ago

@johnbyrneio to fix the issue just run make install-packer-sdc and then make generate this should generate the missing files. It has to do with missing documentation that is auto generated

johnbyrneio commented 4 months ago

@cjlapao I just worked that out. Should be good now.

cjlapao commented 4 months ago

@johnbyrneio thanks for the contribution, merged it