Parallels / parallels-vscode-extension

Parallels Visual Studio Code

MIT License

27 stars 7 forks source link

refactor: use `process.env.HOME` for consistent home path retrieval #95

Closed Neved4 closed 2 months ago

Neved4 commented 2 months ago

Description

Addresses an issue where the retrieval of the home path was inconsistent across different operating systems in the getFoldersBasePath function.

Summary

Replaced cp.execSync(`echo $HOME`) with process.env.HOME to retrieve the home path.
Removed unnecessary string manipulation that replace()s on "\r\r" and "\n".

Checklist:

[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have run tests (npm run test) that prove my fix is effective or that my feature works
[x] I have run format check (npm run format-check) that shows any code inconsistency
[x] I have updated the CHANGELOG.md file accordingly

cjlapao commented 2 months ago

@Neved4 Thank you for this fix, this is now merged and will be released in the next patch

Neved4 commented 2 months ago

Thank you!