search

Parallels / rq-dashboard

Flask-based web front-end for monitoring RQ queues
http://python-rq.org/
Other
1.45k stars 328 forks source link

instance selector shows full redis url with password #359

Closed jtrip closed 1 year ago

jtrip commented 4 years ago

Seems like this should be avoided.

Screen Shot 2020-09-01 at 5 59 43 PM

It might also be more helpful if it had a shorter representation. like just host:port

jtrip commented 4 years ago

a possible simple update / workaround:

change line 98 in templates/rq_dashboard/dashboard.js

text: instance.split('@')[1]

Although I think perhaps the password should not be passed in the api results at all. I could take a look at that later maybe.

eoranged commented 4 years ago

Thanks for report, @jtrip! What version if rq-dashboard do you use?

jtrip commented 4 years ago

You're welcome :) thanks for the consideration.

This is on VERSION = '0.6.1'