search

Parallels / rq-dashboard

Flask-based web front-end for monitoring RQ queues
http://python-rq.org/
Other
1.45k stars 328 forks source link

Fix for click error #383

Closed vaal- closed 1 year ago

vaal- commented 3 years ago

Since version 8 of the click, the default value for the parameter with the multiple flag cannot be None. This causes an exception ValueError: 'default' must be a list when 'multiple' is true.

https://click.palletsprojects.com/en/8.0.x/changes/#version-8-0-0 "The default value for a parameter with nargs > 1 and multiple=True must be a list of tuples. #1649"

vaal- commented 3 years ago

The CI error is because the RQ repository started using f-string which is not supported in python 3.5 https://github.com/rq/rq/commit/40b90946a7ea04ee0ebd56c24529453c28baf56a

jace commented 3 years ago

default=None still seems to work. The other one with default=['.'] is the blocker for me.

vaal- commented 3 years ago

default=None still seems to work. The other one with default=['.'] is the blocker for me.

['.'] is also used in the RQ https://github.com/rq/rq/blob/master/rq/cli/cli.py#L65

cjlapao commented 1 year ago

@vaal- this is already in the base code