Param302 / SocialRepo

Social Repo - Your Social Handles Repository in a chrome extension.
Apache License 2.0
39 stars 35 forks source link

links_added : codechef,exercism,hackerrank,insta,pintrest #38

Closed DevvMaurya closed 1 month ago

DevvMaurya commented 1 month ago

links_Added

Description

codechef ,exercism, hackerrank, insta, pintrest all the mentioned platforms links added.

I have doubt about Discord link in social_links.json . plz check it . As per I believe it should be "https://discord.com/channels/@me" like this. If I'm wrong correct me.

I Noticed that already some links are in social_links file but not ticked in social_links.md file. make sure you correct it.


Issue Ticket Number

Fixes #(issue_number)


Type of change


Checklist:

Param302 commented 1 month ago

Hey @DevvMaurya ,

Thanks for your valuable contribution to SocialRepo. I am merging it to main branch.

I have doubt about Discord link in social_links.json . plz check it . As per I believe it should be "discord.com/channels/@me" like this. If I'm wrong correct me.

Regarding the discord dm link, both are valid, channels/users both are accepted.

I Noticed that already some links are in social_links file but not ticked in social_links.md file. make sure you correct it.

social_lnks.md file is having social links and only those are checked whose logo are added. I think it's creating a confusion I will improve it. Thanks!

Looking forward for more contributions. :D Keep Contributing! 🙌

DevvMaurya commented 1 month ago

Ohkay I thought that social_link.md file check those which links were added. 😅 You should named it as social_icon_list.md It's my suggestion.

Param302 commented 1 month ago

Ohkay I thought that social_link.md file check those which links were added. 😅 You should named it as social_icon_list.md It's my suggestion.

Thanks for the suggestion, actually the main idea behind creating social-apps.md was to keep a log and maintains the social media apps/website names which has public profile link feature.

I have updated the social-apps.md now, check once.