search

ParasolJS / parasol-es

ES6 module for interactive visualization of multi-objective optimization problems
https://parasoljs.github.io/
MIT License
26 stars 5 forks source link

implicit normalization behavior in weightedSum #32

Open dominikandreas opened 3 years ago

dominikandreas commented 3 years ago

I would like to have a weighted sum without any normalization, but that doesn't seem to be possible.

As can be seen here, normalization is still applied to the weighted sum range at the end: https://github.com/ParasolJS/parasol-es/blob/31fcdaeb2358873d473f5aa8a08eb94bc232f8d8/src/api/weightedSum.js#L48-L55

Whereas the norm parameter only controls normalization of the input data normalization.

In my opinion the default behavior should be to normalize neither, because it isn't something that I as a user would expect when I call a "weightedSum" operation. At the very least there should be an option to disable both forms of normalization

Edit: Just noticed there's the additional "score" property that isn't normalized. I guess that does what I want, but still think this behavior is strange

joshhjacobson commented 3 years ago

Thanks for your request! It's been awhile since I've worked on this project and I don't have much time to maintain it at this point. However, if you'd like to submit a quick pull request, I'd be happy to review it and get something merged.

Hopefully the "score" property has been working for you in the meantime!