Closed jellegerbrandy closed 6 years ago
Should the player create a node if none is passed in or always rely on having a node provided?
My heart says it should create a node itself :-) I'm just not sure about the start parameters... I'd say for now the easist fix is to keep the current code as the default if no node instance is provided to the contructor.
Ah, if you've done this, can you also upgrade the reference in the portal package.json?
Working on this now
done
here we create a new node ach time: https://github.com/Paratii-Video/paratii-mediaplayer/blob/master/src/js/index.js#L17
Instead, the constructor must take "node" argument, so that we can pass it an existing (arleady started, shared with other vis) node