Paratii-Video / paratii-mediaplayer

v0.0.2 of the Paratii Player, with a sleeker UI, plugin-oriented architecture
http://paratii.video
GNU General Public License v3.0
15 stars 2 forks source link

Player must accept an existing node in the contructor #25

Closed jellegerbrandy closed 6 years ago

jellegerbrandy commented 6 years ago

here we create a new node ach time: https://github.com/Paratii-Video/paratii-mediaplayer/blob/master/src/js/index.js#L17

Instead, the constructor must take "node" argument, so that we can pass it an existing (arleady started, shared with other vis) node

bent0b0x commented 6 years ago

Should the player create a node if none is passed in or always rely on having a node provided?

jellegerbrandy commented 6 years ago

My heart says it should create a node itself :-) I'm just not sure about the start parameters... I'd say for now the easist fix is to keep the current code as the default if no node instance is provided to the contructor.

jellegerbrandy commented 6 years ago

Ah, if you've done this, can you also upgrade the reference in the portal package.json?

bent0b0x commented 6 years ago

Working on this now

bent0b0x commented 6 years ago

done