Paratii-Video / paratii-mediaplayer

v0.0.2 of the Paratii Player, with a sleeker UI, plugin-oriented architecture
http://paratii.video
GNU General Public License v3.0
15 stars 2 forks source link

Gather statistics on player bundle size #34

Closed bent0b0x closed 6 years ago

bent0b0x commented 6 years ago

@felipegaucho has requested this

jellegerbrandy commented 6 years ago

I'm not sure what this is for, but I assume for optimiziation

In that case, I think we are interested in loading times more than "bundle size", and specifically times like "how long before you see a complete page", "how long before you can click on something", "how long before a video starts playing".

These are of course very much related to the size of the code - but it is not the same.

For the record, here: a pattern that @bent0b0x has introduced and I'd like to leverage is to reduce loading times by load releveant pieces of the app only when they are needed. So there is no single "bundle" (there may be different bunldes at different entry points, like we already have with portal vs embed)

felipegaucho commented 6 years ago

Yes, for optimisation. I propose keeping track of minified bundle size (for the embedded player, 'standalone', only); startup time; and playback failure rates, for now.

@bent0b0x and @ya7ya naturally come to mind, but maybe @Leeaandrob can help us streamline the process or use a proper tool/flow.

(for ref: https://mux.com/blog/the-four-elements-of-video-performance) (for ref2: https://github.com/lucasrodcosta/clappr-nerd-stats | plugin for clappr stats)

felipegaucho commented 6 years ago

Closing this in favour of tracking metrics here: https://github.com/Paratii-Video/paratii-mediaplayer/wiki/Tracking-performance-metrics

It'd be great if @ya7ya could point there the change in bundle size and corresponding PR for optimisation that happened recently (I couldn't find it).

Later on we can get stats on the legacy player.