search

Paratii-Video / paratii-mediaplayer

v0.0.2 of the Paratii Player, with a sleeker UI, plugin-oriented architecture
http://paratii.video
GNU General Public License v3.0
15 stars 2 forks source link

Full screen option not appearing on Twitter #41

Closed felipegaucho closed 6 years ago

felipegaucho commented 6 years ago

To check, follow this link: https://twitter.com/jellegerbrandy/status/967199706207195136

Note it is present on the /embed route: https://portal.paratii.video/embed/JSeRyKaS0ebp

bent0b0x commented 6 years ago

It is appearing now, but the button is not working on twitter. @jellegerbrandy how was this tweet created? Did you use an embed code w/ iframe or just post a link to video?

I wonder if this has to do w/ allowfullscreen iframe attribute, but let me know what you think.

bent0b0x commented 6 years ago

@felipegaucho, I am pretty sure it is impossible to enable full-screen on twitter (please do correct me if I'm wrong, though). I just tested and when youtube is embedded on twitter their full-screen button is grayed out. There is an iframe attribute (allowfullscreen) that is not set on twitter cards. This twitter developer forum post seems to also imply that this not possible.

@pedrocasa assuming this is correct, should we also gray out/disable our full-screen button? Or just remove it when embedded on twitter?

pedrocasa commented 6 years ago

I think removing is the beest option