Closed felipegaucho closed 6 years ago
@pedrocasa I think you mentioned you have a design for this but can you post it here?
FYI @felipegaucho I've built out the surrounding logic/functionality for the quality selector. Once the design is ready I can implement it and we'll be good to go:
☝️ I do not think it is in there. Could you reference the design directly in this issue? It is much easier to work w/ when it is put in the specific issues 😄
@felipegaucho @pedrocasa this isn't perfect yet but lmk what you think so far
The dot should be locked on the center and the values should move
Also, I don't know if u should focus on the small details but if u take a look at the specs (https://github.com/Paratii-Video/paratii-mediaplayer/issues/32) the panel of the player has 95% of opacity.
Do we really want to do dragging here? Is clicking ok for now? @pedrocasa.
Just asking because it will be much quicker 😄
Sure, don't need to drag. Analysing it again maybe it's not even a good idea to drag it. What I want to keep about this idea is the dot blocked and the values moving
For sure, I like that too. I'll work on that tonight!
Hen Ben, I've Updated the video resolution menu for screens bigger than 664px ( still working o screens that are bigger than this - but for now we've already a re-start)
link on #32
Along the lines of https://github.com/Paratii-Video/paratii-mediaplayer/issues/46, we don't have this control yet. It was working pretty well on the legacy player, and I assume we just need to port the code.
@pedrocasa do we have specifications for what happens once the "engine icon" button is clicked?