search

Paratii-Video / paratii-mediaplayer

v0.0.2 of the Paratii Player, with a sleeker UI, plugin-oriented architecture
http://paratii.video
GNU General Public License v3.0
15 stars 2 forks source link

Implement thumbnail "video previews" when scrubbing #56

Closed felipegaucho closed 6 years ago

felipegaucho commented 6 years ago

I suppose this means

[ ] Designing it @pedrocasa; [ ] Making sure we're generating a spritesheet at some point (@ya7ya?); [ ] Implementing the actual plugin to display them.

I imagine this is not of much use at this point, but will pin it here regardless https://www.npmjs.com/package/clappr-thumbnails-plugin

bent0b0x commented 6 years ago

@felipegaucho yes that plugin is not something we can directly use, but thanks for pinning it because it will be a good model for how we can build ours 👍.

felipegaucho commented 6 years ago

@jellegerbrandy brings the point we shouldn't frame small things like this on scope (e.g. getting this spritesheets thing on @ya7ya's table, have Pedro think about this design, etc), and rather implement them as they become requested, or make it easier for devs to do do it for their needs through documentation. I tend to agree, and would happily close this issue or just not prioritise it for now.

bent0b0x commented 6 years ago

My two cents: we definitely do not need to prioritize this right now. But at the same time for us to be a kickass player we're going to want this feature eventually. I wouldn't mind keeping it open for a while and waiting for when most of our other priorities have been completed, just so that we do not forget about this forever. But also okay closing if we are not sure we are ever going to do it.

jellegerbrandy commented 6 years ago

Good point, ben. I think that yes we should have a kickass player, but the kickassery comes from the fact that it is a player with integrated crypto, not because we have lots of features that others already have. So I say close this in favor of focusing on the new and never-done - before stuff

On Tue, Mar 20, 2018, 12:40 AM Ben notifications@github.com wrote:

My two cents: we definitely do not need to prioritize this right now. But at the same time for us to be a kickass player we're going to want this feature eventually. I wouldn't mind keeping it open for a while and waiting for when most of our other priorities have been completed, just so that we do not forget about this forever. But also okay closing if we are not sure we are ever going to do it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Paratii-Video/paratii-mediaplayer/issues/56#issuecomment-374462909, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPuPS8xE5ti2i8riXVfpq6Au9YXHgImks5tgHoYgaJpZM4Sumf_ .

bent0b0x commented 6 years ago

Works for me!