search

Paratii-Video / paratii-mediaplayer

v0.0.2 of the Paratii Player, with a sleeker UI, plugin-oriented architecture
http://paratii.video
GNU General Public License v3.0
15 stars 2 forks source link

Create new demo app/page #7

Closed bent0b0x closed 6 years ago

bent0b0x commented 6 years ago

With the refactor of the lib, the demo page no longer works/loads the player correctly. This needs to be resolved to have a dev experience outside of paratii-player.

jellegerbrandy commented 6 years ago

I don't get it.

bent0b0x commented 6 years ago

When I say demo app, I mean index.html that exists in this repo. This was used initially as the POC for getting the clappr player working. With our refactor of of the js, in terms of how we expose the apis in the lib, this index.html displays nothing.

It would be helpful to maintain index.html (and supporting scripts) within this repo to exist as a demo/sandbox environment in which we can quickly develop changes, rather than having to always yarn link in the bigger project.

Let me know if this still doesn't make sense, happy to discuss.

eliawk commented 6 years ago

@bent0b0x ok i get your point now, but do you think we will need this demo page?

bent0b0x commented 6 years ago

I think it would be useful (and also I do not think it will be difficult to do).

Let's say we need to make a minor UI change on the volume bar or something; if we have this demo page we can spin that up and make the change just by running paratii-mediaplayer. If we do not have this we need to spin up paratii-player and navigate to a video just to get a look at the player. This would get especially cumbersome if we are making many changes.

For example having this demo page independent of paratii-player will make it much faster to iterate on the UI when we get back to customizing the clappr skin, I think.

But if you all disagree, we can certainly abandon this issue, open to another point of view

jellegerbrandy commented 6 years ago

I agree