Open jellegerbrandy opened 7 years ago
@pedrocasa asks: "I still don't understand why we need so many options in that modal (is there another way to make it more automatic and simple?)"
We probably should to it just as youtube does:
what do you think @jellegerbrandy @pedrocasa?
I Agree with @jellegerbrandy and @jrgarou about the "social share" ( direct to twitter, facebook, blabla )
My only concern is about the options of capabilities and sizes of the embed sharing.
@enricocicconi
@jellegerbrandy
"We probably should to it just as youtube does"
@pedrocasa
"My only concern is about the options of capabilities and sizes of the embed sharing." "Do we need it all?"
I think in that stage user (mostly creators maybe?) needs a deep control of the embeded player capabilities, look and feel etc.
"Does the user needs to worry about what is the correct size for embedding it on his blog (what happens when the viewer of his blog open it on a mobile device that's smaller than the mini size ?)"
It depends: mini, tiny ect. operate on two aspects: sizes and features. Sizes can be customized by the user/creators directly on the embed code. Maybe the best approach is to rename "tiny" and "mini" with something like "lite" "minimal" etc.
Sizes are just a way of saying: "ok man, you have chosen 'tiny' so this is the minimum suggested size for this type of setting.
Responsive embeded players (youtube, vimeo etc.) is quite debated among frontenders:
"What happens when the user defines autoplay and the video is a pay-per-view"
Let's take a choice: my opinion is that autoplay option is disabled for pay-per-view video!
re-uploaded https://github.com/Paratii-Video/paratii-player/issues/162
I made a two-steps modals for the embed function as a test
The actual "embed modal" seems a bit tight to me
I create the share modal with two "steps"(works on frontend branch):
What does the "playsinline" option do? @enricocicconi
the actual share modal is a bit tight One of the solutions is to add one step modal as the flow that I re-uploaded
@pedrocasa iOS (on iphone) by default play the video in fullscreen. Playsinline allows the video to play directly inside the iframe without going fullscreen.
referring to the design on #162
Need to define the content of the sharing/embed modal.
Current modal for embedding is this:
Proposal is part of #162 (my screen capture refuses to select from the pdf) and has two options (link and embed snippet) together.