Paratii-Video / paratii-player

Probably the world's 1st in-player token wallet (v0.0.1 of the Paratii embeddable web player).
http://paratii.video
GNU General Public License v3.0
41 stars 11 forks source link

player should pass the tests on playerjs.io #236

Open geckoslair opened 6 years ago

geckoslair commented 6 years ago

Developing related videos at video playback ended I've noticed that we need a hook/events-watcher approach. For example playing, pause, ended, replaying are not well centralized/binded and sometimes there is discordance between frontend and player states.

jellegerbrandy commented 6 years ago

Yes, we do.

Let us implement the player.js specs : https://github.com/embedly/player.js/blob/master/SPEC.rst This seems somethign relatively easy to do using adapters https://github.com/embedly/player.js#adapters

We need to do this anyway for #178 .

geckoslair commented 6 years ago

Hi player.refactor dream team! This issue in composed by three subissues:

is it good for you?

geckoslair commented 6 years ago

a possibile flow could be:

var player = new Paratiiplayer(); yahyamagicfunctions(player) playerJSadapter(player)

geckoslair commented 6 years ago

ref #175

geckoslair commented 6 years ago

using gateway: http://playerjs.io/test.html?url=https%3A%2F%2Fstaging.paratii.video%2Fplay%2F6%3Fplaylist%3D2

without gateway: http://playerjs.io/test.html?url=https%3A%2F%2Fstaging.paratii.video%2Fplay%2F8%3Fplaylist%3D4

jellegerbrandy commented 6 years ago

Any updates on this? Especially regarding "make player,js and player.html driven by video tag states/events ( video tag wiil be our source of truth) @eliawk"?

geckoslair commented 6 years ago

Actually i've done a fast refactor in order to fix binding issues. There's still some work to do.

eliawk commented 6 years ago

for the records http://clappr.io/

jellegerbrandy commented 6 years ago

It seems to me we are trackign two separate things in this issue: (1) does our player play nice with playerjs.io and (2) shoudl we refactor, and how?

I'm opening a new issue for (2), and will rename this one.