search

Paratii-Video / paratii-player

Probably the world's 1st in-player token wallet (v0.0.1 of the Paratii embeddable web player).
http://paratii.video
GNU General Public License v3.0
41 stars 11 forks source link

resolution controls hooked up #378

Closed ya7ya closed 6 years ago

ya7ya commented 6 years ago

This hooks up the resolution controls made by @jrgarou 🙏 to HLS player to allow users to choose the resolution of the content

mrocha94 commented 6 years ago

Do all videos always have these 5 resolutions? The default is 144p, I think it's not a good default value (maybe saves the last resolution used in another video? Try always the best resolution?) The p is missing (144p, 240p)

For my curiosity, is possible to add a "auto" resolution option? (there is a "autoLevelEnabled" option on hls)

I can try to implement any of the topics above if needed.

ya7ya commented 6 years ago

Hey @mrocha94 , Yes , currently all videos have the 5 resolutions because the transcoder is currently limited to 720p, and since we're moving to clappr player soon, which has this function implemented i thought we shouldn't create a template for brevity.

I'll add the missing p 👍 😄

The auto resolution doesn't work great right now because the IPFS stat function isn't perfect yet. so calculating bandwidth isn't as straightforward. I'm working on this issue.

The 144p default was to shave time off the initial load time to get the playerjs.io tests to succeed. I think we'll be able to update that soon with the upggrades to IPFS performance.