search

Paratii-Video / paratii-portal

Component-based web-interface for uploading, browsing and organising content of Paratii's P2P network.
GNU General Public License v3.0
12 stars 5 forks source link

Revisit our color theming #670

Closed bent0b0x closed 6 years ago

bent0b0x commented 6 years ago

Right now we have a theme file. It manages all of the colors throughout the entire app, but I would argue in a not-so-helpful way. If we want to change the color scheme of the app we'd have to evaluate every specific color in the theme file and swap it with another color. This is not ideal. In addition, this file is going to keep growing as the app grows. It is not scaleable.

Proposed Solution Our theme colors should merely alias colors w/ specific names like backgroundColor, textColor, secondaryTextColor, accentColor, etc. This way we will end up w/ a manageable amount of colors and if we do things right switching themes would be fairly trivial.

Interested to hear thoughts from @jrgarou

jrgarou commented 6 years ago

In the beginning, @pedrocasa and I have tried to define some color patterns(text with color X and titles with color Y with some variations, main/dark/light colors for backgrounds, etc) but we've done a lot of changes(design and UI mostly), so I decide to do that by component for now.

I totally agree with you, @bent0b0x. We need to do that, but we still defining how the things must be.

bent0b0x commented 6 years ago

Sounds good. Yes we'll definitely want to work with @pedrocasa on this when the time comes

jrgarou commented 6 years ago

Working on that in https://github.com/Paratii-Video/paratii-portal/tree/fix/ui-design

jrgarou commented 6 years ago

Working progress in https://github.com/Paratii-Video/paratii-portal/pull/769