Paratii-Video / paratii-portal

Component-based web-interface for uploading, browsing and organising content of Paratii's P2P network.
GNU General Public License v3.0
12 stars 5 forks source link

Embed player is using a different wallet #766

Closed pedrocasa closed 6 years ago

pedrocasa commented 6 years ago

I was trying to watch the embedded videos (twitter) in the same browser where my account is saved and the addresses are not the same

screen shot 2018-07-05 at 4 40 13 pm

screen shot 2018-07-05 at 4 13 27 pm

I tried both staging and portal.paratii

jellegerbrandy commented 6 years ago

Good point. The reason is taht in the portal you are logged in, and in the embedded version you are not (and using the anon account, which is different)

This is of course confusing. Basically, in the portal, as it is now, in "anonymous mode" the address info is not accessabile via the UX; while in the embedded version it is right there under the profile button. We should make both cases behave the same: at this point, i'd say to also hide the account info in anon mode.

bent0b0x commented 6 years ago

☝️ I think it is indeed a bug that we are showing the account info in anon mode. As far as I can understand that was not intended 😬

jellegerbrandy commented 6 years ago

We can remove the profile icon from the embedded version alltogether.

On Fri, Jul 6, 2018 at 1:59 PM Ben notifications@github.com wrote:

☝️ I think it is indeed a bug that we are showing the account info in anon mode

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Paratii-Video/paratii-portal/issues/766#issuecomment-403013360, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPuPY3v4JDMHrYZQXeNyOvBvD_eZUm3ks5uD1E7gaJpZM4VEb2T .

bent0b0x commented 6 years ago

@jellegerbrandy @pedrocasa so actually, the profile icon is shown only in the embedded version and this was done intentionally. We hide it in the portal version because we already have a more extensive profile/account flow there.

But, as we are discovering here, we only see data about the anonymous wallet in the embedded player, which is fairly useless. As I see it, we have at least two options:

Thoughts?

jellegerbrandy commented 6 years ago

Strongly for "remove"

On Sun, Jul 8, 2018 at 1:19 AM Ben notifications@github.com wrote:

@jellegerbrandy https://github.com/jellegerbrandy @pedrocasa https://github.com/pedrocasa so actually, the profile icon is shown only in the embedded version and this was done intentionally. We hide it in the portal version because we already have a more extensive profile/account flow there.

But, as we are discovering here, we only see data about the anonymous wallet in the embedded player, which is fairly useless. As I see it, we have at least two options:

  • remove this button altogether OR
  • design and implement login/secure flow in the embedded player

Thoughts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Paratii-Video/paratii-portal/issues/766#issuecomment-403249112, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPuPU5pg0pIdgblkBKSSx7yIGl3tgm-ks5uEUHkgaJpZM4VEb2T .

pedrocasa commented 6 years ago

I Totally agree with Jelle