Fix target=_blank bug - Githubissues

Paratron / hookrouter

The flexible, and fast router for react that is entirely based on hooks

1.5k stars 90 forks source link

Closed tugceakin closed 3 years ago

tugceakin commented 3 years ago

Expected target=_blank attribute opens the linked document in a new window or tab

Actual target=_blank doesn't change the behavior of the link.

tugceakin commented 3 years ago

@Paratron Could you review the PR?

Paratron commented 3 years ago

Merged! Interesting that no one catched this before :D Thanks for the fix :)

tugceakin commented 3 years ago

Thank you 🙏

ogazitt commented 3 years ago

This commit introduces a syntax error (two close parens) on line Link.js:22.