Maintenance: update devDependencies and peerDependencies, fix npm audits and make tests run - Githubissues

Paratron / hookrouter

The flexible, and fast router for react that is entirely based on hooks

1.5k stars 90 forks source link

Maintenance: update devDependencies and peerDependencies, fix npm audits and make tests run #161

Open jacklrs opened 3 years ago

jacklrs commented 3 years ago

There is raviger which make this pull request obsolete ...

Hi, I had issues install this package in context of npm7 and packages depending on react 7.x . Since I like to go further with this package (thx to this nice approach!) and I like to help try to update it instead of apply possible workarounds with npm install flags (e.g via --legacy-peer-deps flat), here the changes:

Updated peerDependencies to be compatible with npm7 and packages depending on react 17.x
Corrected package version to mach current latest version (1.2.5)
Fixed all npm audit findings by updating all devDependencies
Fixed all tests to run successfully
added eslint as devDependency

Thx in advance for any feedback and potential merge!

pramodkandel commented 3 years ago

I really like hookrouter, and I had this problem recently with npm7 as well. Hopefully this patch gets merged.