Jackson IO Library - Githubissues

AterAnimAvis commented 6 months ago

IO Jackson Implementation.

Based off #15 for the AdapterPresenceTest

TODO:

[ ] Decide on the correct version for FeatherModule.VERSION
[ ] Fix up docs on JacksonTest
[ ] Potentially redesign the ignoreNonDocumented implementation
[ ] Add more documentation :harold:.

Things noticed:

[ ] ~~ParameterData uses a signed byte for the index, should really be unsigned (0-255)~~ #10
[ ] IllegalArgumentException used in places instead of JsonParseException/JsonDataException
[ ] No tests for the Manifest?

Closes #12

marchermans commented 6 months ago

Just a question: What is the usage of this? I have no problem with adding it, but I want to know why we have this module.

AterAnimAvis commented 6 months ago

https://github.com/ParchmentMC/Feather/issues/12 Jackson happens to be the other leg of the main three JSON libraries for Java (GSON, Jackson, Moshi), I believe we also got a request for it at some point (looking into it slightly more, it was likely from someone making a Discord Bot since both JDA and Discord4J pull in jackson, although can't find the original message). It semi serves as a good alternative for Moshi since that moved to Kotlin.

ParchmentMC / Feather

Jackson IO Library #16