search

ParchmentMC / Parchment

Repository for the Parchment mappings data.
Creative Commons Zero v1.0 Universal
248 stars 79 forks source link

Update to 1.19.4 #198

Closed PiTheGuy closed 1 year ago

sciwhiz12 commented 1 year ago

This PR is currently on hold due to some issues with the Blackstone metadata, specifically with the ordering of record component data, which are causing issues during validation.

sciwhiz12 commented 1 year ago

The Blackstone metadata issue has been fixed for 1.19.4, 1.20, and 1.20.1. (Other versions will be fixed on a case-by-case basis.)

This means the single validation error given by validateData for EntitySelectorOptions$Option is a genuine error that needs to be resolved.

Also, I accidentally sent my above review too early -- I haven't reviewed the PR in full yet.

sciwhiz12 commented 1 year ago

Last remaining 1.19.3 PR has been merged, so off to 1.19.4 we go!