search

ParchmentMC / Parchment

Repository for the Parchment mappings data.
Creative Commons Zero v1.0 Universal
248 stars 79 forks source link

redstone signal javadocs and related refactors #200

Closed SpaceWalkerRS closed 1 year ago

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

SpaceWalkerRS commented 1 year ago

No worries, thanks for the review! There have been some changes to this code in 1.20 so look forward to another PR for that ^^

(Also, the fact that redstone diodes have the opposite of the instinctual facing -- their facing is aligned to ther input, rather than their output as with all other blocks like dispensers, droppers, hoppers, etc. -- is fun and confusing. 😄)

Yeah that's quite baffling to be honest - I don't know if it's a remnant of old Notch code or what, but surely that's something that could/would have been fixed in 1.8, if not during The Flattening? Oh well.