search

ParchmentMC / Parchment

Repository for the Parchment mappings data.
Creative Commons Zero v1.0 Universal
258 stars 82 forks source link

Added Javadoc and changed parameter names in relation to `ChunkTrackingView` (fixed inaccurate javadoc) #283

Closed FamroFexl closed 3 months ago

FamroFexl commented 3 months ago

Javadoc was provided for several ChunkTrackingView methods. Several parameter names were changed or flipped to better reflect their purpose.

Changing the searchAllChunks parameter names in the ChunkTrackingView class triggered hundreds of edits in commit b0041f886524887058babf09bd15a09928e2ef99 from enigma for some reason.

PiTheGuy commented 3 months ago

A recent enigma update changed the order in which mappings are saved. Run the santinizeData gradle task and it should fix it.

FamroFexl commented 3 months ago

sanitizeData task run in commit 7bf753ec733f55930069e1e5f12459d7ed968f52

sciwhiz12 commented 3 months ago

Thanks! We'll look into the changed ordering written out by Enigma and match ours in the future. (It seems simple at least -- the order of inner classes is now sorted rather than being in encounter order from the bytecode, I believe.)