search

PardeeCenterDU / IFs-Issues-Tracking

This repository only holds the list of bugs that have been reported for IFs. Anyone may add a bug report, but please look to see if your issue has already been added!
2 stars 0 forks source link

year columns are not sorted #258

Closed quciet closed 4 months ago

quciet commented 4 months ago

Hi there,

I think this is not a common case but the dataset is really giving me a hard time to import. Please look at the CarbonTot tab in the Excel file attached. What happened is that IFs correctly covered the data from long form to wide form, however, the columns of years are not sorted in the resultant table. IFs correctly extract the earliest and the most recent values from the first year and last year where data are available, but the order of year columns are wrong. image

One additional problem I encountered with this dataset was that when I clicked on Excluded to see countries that have no matches in IFs, it threw an error, image

CDIAC_national_1751_2020.xlsx

PardeeCenterIFs commented 4 months ago

First issue, related to the order of years, making sure years are sorted, that has been implemented now.

Second issue, logic is case sensitive, so it is possible that found countries are more than NR, since there could be some in uppercase and others in lowercase. We have increate the number of possible countries to NR * 2. This second issue is caused by countries like Germany saved both as Germany and GERMANY. Same for Sudan and Vietnam.

This fix will be included in version 8.18.

quciet commented 4 months ago

First issue, related to the order of years, making sure years are sorted, that has been implemented now.

Second issue, logic is case sensitive, so it is possible that found countries are more than NR, since there could be some in uppercase and others in lowercase. We have increate the number of possible countries to NR * 2. This second issue is caused by countries like Germany saved both as Germany and GERMANY. Same for Sudan and Vietnam.

This fix will be included in version 8.18.

Thank you so much! Yes, I was guessing that different country names for the same country might cause the issue. This fix could be a big help as people can worry less about country concordance!

BTW, a related question, does this mean that we have to make sure, in the long format of that country concordance table in IFs, there can not be any N to M match? Instead, we can only have 1 to N match for each country/region in IFs.

PardeeCenterIFs commented 4 months ago

We can have N to M match, but if N M > 2NR, then we will get the error again. Unfortunately changing the size of the array dynamically was not working, not sure why, so I just brute forced it to 2*NR.