search

PardeeCenterDU / IFs-Issues-Tracking

This repository only holds the list of bugs that have been reported for IFs. Anyone may add a bug report, but please look to see if your issue has already been added!
2 stars 0 forks source link

remove some old energy preprocessros? #278

Closed quciet closed 4 weeks ago

quciet commented 3 months ago

These preprocessors have not been updated for a while and we cannot find them from the original data source (WRI) anymore, should we remove them from the model? I do believe the information from these tables are already covered by data from the IEA. We purchase data from IEA every two years and they cover energy production and consumption across different energy types.

SeriesEnConPhoto, Energy consumption, photovoltaic solar
SeriesEnConWind, Energy consumption, wind
SeriesEnConElec, Electricity consumption total in BBOE
SeriesEnProdGeoTherm, Energy production, geothermal SeriesEnProdTideWave, Energy production, tide, wave, and water
SeriesEnProdSolar, Energy production, solar

Thanks!

BarryBHughes commented 3 months ago

Yutang,

The data on these renewable energy sources should be best in IEA rather than WRI, so as long we have series updates every 2 years from IEA I think we are ok! But production and consumption patterns for them are changing rapidly, so we will want to update with new releases as soon as we can.

Barry

Barry B. Hughes, Distinguished University Professor Senior Scientist and Mentor Frederick S. Pardee Center for International Futures Josef Korbel School of International Studies University of Denver, Denver, Colorado 80208 USA Mobile: +1 303 847 1828 Connect with the Pardee Center and IFs Onlinehttps://korbel.du.edu/pardee Connect with my web pagehttps://korbel.du.edu/pardee/about/history/founder

From: Yutang @.> Sent: Thursday, March 14, 2024 2:23 PM To: PardeeCenterDU/IFs-Issues-Tracking @.> Cc: Barry Hughes @.>; Assign @.> Subject: [EXTERNAL] [PardeeCenterDU/IFs-Issues-Tracking] remove some old energy preprocessros? (Issue #278)

These preprocessors have not been updated for a while and we cannot find them from the original data source (WRI) anymore, should we remove them from the model? I do believe the information from these tables are already covered by data from the IEA. We purchase data from IEA every two years and they cover energy production and consumption across different energy types.

SeriesEnConPhoto, Energy consumption, photovoltaic solar SeriesEnConWind, Energy consumption, wind SeriesEnConElec, Electricity consumption total in BBOE SeriesEnProdGeoTherm, Energy production, geothermal SeriesEnProdTideWave, Energy production, tide, wave, and water SeriesEnProdSolar, Energy production, solar

Thanks!

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/PardeeCenterDU/IFs-Issues-Tracking/issues/278__;!!NCZxaNi9jForCP_SxBKJCA!SHnDwQ1tOj-osv34aYrYPxec56zZ13HDV_InE0AJuz5NV5YoOCrHCiPf4drFg6f86mKQ7ZALrDDQsreny703r84$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ATOQD2HQG5NRI2EP7JDUNFDYYIBJNAVCNFSM6AAAAABEWZHYNCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4DOMRQGU3DCMQ__;!!NCZxaNi9jForCP_SxBKJCA!SHnDwQ1tOj-osv34aYrYPxec56zZ13HDV_InE0AJuz5NV5YoOCrHCiPf4drFg6f86mKQ7ZALrDDQsrencWiu8C4$. You are receiving this because you were assigned.Message ID: @.**@.>>

quciet commented 3 months ago

@BarryBHughes Appreciate this quick response! The subscription to IEA is funded by the DIPLO team and we will make sure they get updated within the month of their release. There is also a related question to the data we pulled from IEA (https://github.com/PardeeCenterDU/IFs-Issues-Tracking/issues/227). Basically, IEA energy types have more than what are currently covered by IFs, we probably need to restructure the initialization during the next update.

Hi @solox1, based on Barry's comment, I think it is safe to delete those 6 old energy preprocessors from the model code and IFsHistSeries, what do you think? Or at least remove them from the model code to avoid marking them as preprocessors in the DataDict table so that RAs won't need to go through them again next time.

BarryBHughes commented 3 months ago

Quick comment on the removal of WRI series as drivers in the preprocessor --I suspect they were there before we had access to IEA, but we’d want to make sure that they aren’t written in as sources to fill holes in IEA data (e.g. if WRI had estimaes of Palestine and IEA did not).

From: Yutang @.> Sent: Thursday, March 14, 2024 2:44 PM To: PardeeCenterDU/IFs-Issues-Tracking @.> Cc: Barry Hughes @.>; Mention @.> Subject: [EXTERNAL] Re: [PardeeCenterDU/IFs-Issues-Tracking] remove some old energy preprocessros? (Issue #278)

@BarryBHugheshttps://urldefense.com/v3/__https:/github.com/BarryBHughes__;!!NCZxaNi9jForCP_SxBKJCA!WGjod8CdyahmlIaYYXz1wIX0-uyhsVgo1q_XAK633LoLOo3-3ZIKyuJiw6LFPS82sPAYYkxsfIpGfGdwkrJrXts$ Appreciate this quick response! The subscription to IEA is funded by the DIPLO team and we will make sure they get updated within the month of their release. There is also a related question to the data we pulled from IEA (#227https://urldefense.com/v3/__https:/github.com/PardeeCenterDU/IFs-Issues-Tracking/issues/227__;!!NCZxaNi9jForCP_SxBKJCA!WGjod8CdyahmlIaYYXz1wIX0-uyhsVgo1q_XAK633LoLOo3-3ZIKyuJiw6LFPS82sPAYYkxsfIpGfGdwr029CRc$). Basically, IEA energy types have more than what are currently covered by IFs, we probably need to restructure the initialization during the next update.

Hi @solox1https://urldefense.com/v3/__https:/github.com/solox1__;!!NCZxaNi9jForCP_SxBKJCA!WGjod8CdyahmlIaYYXz1wIX0-uyhsVgo1q_XAK633LoLOo3-3ZIKyuJiw6LFPS82sPAYYkxsfIpGfGdwUJleD9A$, based on Barry's comment, I think it is safe to delete those 6 old energy preprocessors from the model code and IFsHistSeries, what do you think? Or at least remove them from the model code to avoid marking them as preprocessors in the DataDict table so that RAs won't need to go through them again next time.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/PardeeCenterDU/IFs-Issues-Tracking/issues/278*issuecomment-1998453334__;Iw!!NCZxaNi9jForCP_SxBKJCA!WGjod8CdyahmlIaYYXz1wIX0-uyhsVgo1q_XAK633LoLOo3-3ZIKyuJiw6LFPS82sPAYYkxsfIpGfGdw7FomJyY$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ATOQD2AVMORTSQSBRH2U5I3YYID2TAVCNFSM6AAAAABEWZHYNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJYGQ2TGMZTGQ__;!!NCZxaNi9jForCP_SxBKJCA!WGjod8CdyahmlIaYYXz1wIX0-uyhsVgo1q_XAK633LoLOo3-3ZIKyuJiw6LFPS82sPAYYkxsfIpGfGdwWwrqH7o$. You are receiving this because you were mentioned.Message ID: @.**@.>>

PardeeCenterIFs commented 3 months ago

I just checked and we're using them to fill holes after we have checked there's no IEA data, but in all cases where IEA is NULL the values for WRI are 0s from 1999 or earlier, so I think it's better to remove them and let the model put a small seed instead.

quciet commented 3 months ago

I just checked and we're using them to fill holes after we have checked there's no IEA data, but in all cases where IEA is NULL the values for WRI are 0s from 1999 or earlier, so I think it's better to remove them and let the model put a small seed instead.

Sounds perfect! I can make the change on my end (deleting those tables) once you make the change in the code. Let me know!

PardeeCenterIFs commented 4 weeks ago

I have now removed these 6 tables, they will not be used in version 8.26 and forward.