search

Parfuemerie-Douglas / scaffolder-backend-module-azure-repositories

A collection of Backstage scaffolder backend modules for Azure repositories.
https://www.npmjs.com/package/@parfuemerie-douglas/scaffolder-backend-module-azure-repositories
Apache License 2.0
9 stars 21 forks source link

Use azure devops credentials provider #20

Closed sanderaernouts closed 5 months ago

sanderaernouts commented 8 months ago

Recently the AzureDevOpsCredentialsProvider was added to @backstage/integrations to support managed identity and service principal authentication in Azure DevOps.

By leveraging this provider this plugin supports the same authentication options as the plugins and integrations in the core backstage repo.

sanderaernouts commented 8 months ago

I have not yet found a way to extract the URL for the commitAndPush action I think a PR on backstage is required to expose the onAuth callback from isomorphic git.

sanderaernouts commented 8 months ago

Raised this PR in Backstage to expose the onAuth call back from isomorphic git. This seems to be the best (or even the only) way to get the remote URL for the commitAndPush action.

sanderaernouts commented 8 months ago

Tagging contributors: @clemensheithecker, @fosterm-mw, @hevans-dglcom, @JetteBke

sanderaernouts commented 8 months ago

My changes to the Git class, https://github.com/backstage/backstage/pull/20938, should be merged into Backstage soon, I'm hoping they'll make it into the upcoming 1.20.

In the meantime all actions except commitAndPush can be reviewed already (@clemensheithecker @hevans-dglcom)

sanderaernouts commented 8 months ago

https://github.com/backstage/backstage/pull/20938 got merged yesterday, so it should be part of 1.20. I'll update this PR once 1.20 is out.

jackmtpt commented 6 months ago

Is this PR ready to merge? We're running Backstage 1.21.1 and this plugin currently is non-functional - it complains that there is no token set for dev.azure.com. Looking at the changes in this PR it seems like they should fix this issue.

sanderaernouts commented 5 months ago

@jackmtpt, I forked this plugin to our code base because I got no response on this PR. I have a working implementation now using the changes from https://github.com/backstage/backstage/pull/20938 in our code-base. I have updated this PR with my (local) changes. Please have another look.

jackmtpt commented 5 months ago

@hevans-dglcom looks like you merged the most recent PR in this repo - would you mind taking a look at this?