search

ParitoshBh / grav-coder

https://paritoshbh.me
MIT License
28 stars 8 forks source link

FontAwesome fonts do not appear on all pages #21

Closed varun-ramraj closed 4 years ago

varun-ramraj commented 4 years ago

Greetings! Thanks so much for making this theme.

With the latest update, it seems as though fontawesome fonts are not appearing on all pages. I see they appear on Error pages, but not the other ones.

I'm primarily trying to just get the default Github and Linked In icons appearing in the footer. Please let me know if you need more information. I have attached screenshots from my site to show this behaviour:

Normal front page; note the separator dots appear at the bottom (above the copyright), but the three icons are blank.

Screenshot 2020-03-28 at 21 23 42

The error page; note that the icons appear as expected at the bottom:

Screenshot 2020-03-28 at 21 23 57

Many thanks!

ParitoshBh commented 4 years ago

Looks like whatever plugin you're using for displaying the consent form is conflicting with favicons in footer. If I click on the agree button, the page (re)loads and favicons appear just fine the first time but disappear in subsequent loads.

Can you try disabling whatever plugin you're using and try again?

varun-ramraj commented 4 years ago

Thanks @ParitoshBh , that seems to work. I am using a different cookie control mechanism and the page seems to load correctly both before and after accepting.

FYI, I've updated your code to use the latest fontawesome and to be able to render the whole set, instead of just what is part of the "fab" i-class. If you'd like, I can issue a pull request.

ParitoshBh commented 4 years ago

Sure, that'd be nice! I am closing this issue, feel free to create a PR :smile: