search

ParkMyCar / compact_str

A memory efficient string type that can store up to 24* bytes on the stack
MIT License
638 stars 46 forks source link

Implement for sqlx #329

Closed Kijewski closed 9 months ago

Kijewski commented 11 months ago

Mysql and Postgres are untested.

Kijewski commented 11 months ago

I am using namespaced features in this PR now, which would mean that this MSRV is stuck to 1.60. Do you think that's okay?

ParkMyCar commented 11 months ago

I am using namespaced features in this PR now, which would mean that this MSRV is stuck to 1.60. Do you think that's okay?

Yeah I think bumping the MSRV to 1.60 is a good idea! It will also help with https://github.com/ParkMyCar/compact_str/pull/328

Kijewski commented 11 months ago

Yeah, I used a bit too many macros in here. :)

Could you have a look how to update the CI workflow? I don't know exactly how to exclude the test when cross compiling.

ParkMyCar commented 9 months ago

Thanks for the PR @Kijewski!

The CI issue looks to be sqlx-sqlite trying to build libsqlite3-sys, which not surprisingly fails in cross, I ignored the sqlx-* features for x-plat builds with cross. The MSRV check fails because it looks like proptest updates their MSRV again, I'll fix this in a separate PR though!