Closed ParkMyCar closed 11 months ago
@ParkMyCar would be great if you can merge my PR #282
You actually don't need to install a nightly toolchain, just set RUSTC_BOOTSTRAP=1
. Compare: https://github.com/strawlab/iana-time-zone/blob/main/.github/workflows/rust.yml#L111-L138
You actually don't need to install a nightly toolchain, just set
RUSTC_BOOTSTRAP=1
. Compare: https://github.com/strawlab/iana-time-zone/blob/main/.github/workflows/rust.yml#L111-L138
Good to know!
Since there are some open PRs I want to review and merge, for now I'm going to just bump the MSRV workflow to 1.60 so we can get CI green.
1.60 added namespaced features and weak dependencies, which might come in handy if we want to add more integrations without a semver breaking change.
And since 1.60 was released on 2022-04-07, I guess we should not invest any more work into making 1.59 work.
With some recent PRs we hit some merge skews that prevented a test from compiling, this PR fixes those issues. It also bumps the MSRV CI workflow to 1.60, suddenly when running in 1.59 we get the following error:
... which is confusing, since the version of
rkyv
selected satisfies the dependency, and there haven't been any new versions ofrkyv
released in 5 months? It seems related to this issue, https://github.com/rust-lang/cargo/issues/10189, which indicates something further down in the dependency chain is to blame. Haven't had a chance to dig further, so I bumped the MSRV workflow to 1.60