search

ParkMyCar / compact_str

A memory efficient string type that can store up to 24* bytes on the stack
MIT License
558 stars 41 forks source link

Add `const_new()`; remove `new_inline()` and `from_static_str()` #336

Closed Kijewski closed 5 months ago

Kijewski commented 8 months ago

Closes #322.

Please see #322 for an explanation.

ParkMyCar commented 6 months ago

Hey @Kijewski! Thanks again for a great PR!

There seem to be some changes include here that are not related to adding const_new(...) and deprecating new_inline(...) and from_static_str(...), e.g. the ptr APIs and some trait impls. Those look like great changes, but do you mind splitting them into a separate PR?

Kijewski commented 6 months ago

Yeah, that were minor points that I found while walking through the code to do the renaming. I moved it into #350.

ParkMyCar commented 5 months ago

Thanks for separating out the changes!