search

ParkMyCar / compact_str

A memory efficient string type that can store up to 24* bytes on the stack
MIT License
638 stars 46 forks source link

Created CONTRIBUTING.md #345

Closed 0Armaan025 closed 9 months ago

0Armaan025 commented 11 months ago

Hey there! First, if you are reading this, you are amazing!

I'm Armaan and actively taking part in Hacktoberfest and HackSquad, I was contributing to various repos recently and found out this repo (had a lot of contributions.

As always, I jumped and tried to find out "CONTRIBUTING.md" which all the beginners find first to start contributing but unlike other amazing repos, I couldn't find any, "CONTRIBUTING.md" contains a set of guidelines and steps on how to contribute to the project!

This change (separate file on steps and guidelines) will help increase contributors to contribute even more especially beginners, and to make it fun, emojified and engaging for users!

Who doesn't like fun? : D

So, I went ahead and made a separate "CONTRIBUTING.md" file with steps and guidelines, I hope this will help beginners and potentially increase contributors to this amazing repo!

Since I'm not the owner/maintainer of this repo, I do not have full data about the project, so there might be slight mistakes, and I deeply apologise for that.

This PR is free for any modifications/edits.

If this change was not really required, you are free to close this PR or merge it if you want, I'm sorry.

I am hoping for a positive and quick merge!

Thanks and regards, Armaan.

Kijewski commented 11 months ago

I don't get Hacksquad. Please explain it to me. You are wasting hours of your own time and the time of 100+ repos / orgs, just to maybe win a t-shirt. In this time you could just do freelance work, gig work like fiverr, etc. and buy a t-shirt you actually like.

0Armaan025 commented 11 months ago

@kijewski, you are def. right with this, and I respect your decision about this, but I believe HackSquad provides various opportunities along with that to learn about open source, I'm super new to open source and hence contributing to this, a thing can be learnt/understood amazingly if done practically, I'd also recommend you to try HackSquad at least once, it's like without trying and saying, I do not disrespect in any way and apologise if you feel offended, tho, it's really a learning experience for beginners.

Thanks for your advice as well! Thanks and regards, Armaan.

ParkMyCar commented 9 months ago

Thanks @0Armaan025 for the PR. This appears to be part of Hacktober, and a CONTRIBUTING.md requires more thought than I have time for at the moment, so I'm going to close this PR.

I appreciate your interest in open source software though, and wish you the best!