Kotlin DSL - Githubissues

ParkSangGwon / TedPermission

Easy check permission library for Android Marshmallow

1.74k stars 239 forks source link

Kotlin DSL #81

Open lutsenko-yuriy opened 6 years ago

lutsenko-yuriy commented 6 years ago

Adding Kotlin support to project
Building Kotlin DSL which in theory should make code more readable
Some changes in PermissionBuilder like turning String[] permissions into final List<String> permissions which should make code less error-prone
Some changes in ObjectUtils which also should make code less error-prone

JSpiner commented 6 years ago

Because of there is no test code in this project, I'll run code and reply. Thanks

ParkSangGwon commented 6 years ago

@lutsenko-yuriy Sorry, Nowadays I start study kotlin language. When I finish study, I will review your code. Or If many other people approve this PR, I will approve too.

lutsenko-yuriy commented 6 years ago

@ParkSangGwon That's ok. There is actually some room for improvements so I marked this pull request as Work In Progress. Thank you for your reply anyway