ParkenDD / parkapi-sources-v3

MIT License
0 stars 1 forks source link

Add Goldbeck Opening times #77

Closed the-infinity closed 3 weeks ago

the-infinity commented 1 month ago

At https://github.com/ParkenDD/parkapi-sources-v3/pull/68 , we decided to merge Goldbecks data input ignoring the broken opening times. The opening times should be added later.

AbdullahiFatola commented 1 month ago

That's strange, i did not remove the opening times and after checking the Excel data, i discovered that excel automatically formats the value 24:00:00 to 1900-01-01 00:00:00 for "Klinik am Gesundbrunnen". Could that be the source of the problem?

the-infinity commented 1 month ago

The opening times were handled at the parent function map_row_to_parking_site_dict you overwrote without calling the parent. But, if you use the parent, the whole thing crashes because of a lot of invalid data, neither closed nor 1900-01-01 00:00:00 is a valid time. That why this will need more work (and in my opinion, at least 1900-01-01 00:00:00 has to be fixed by Goldbeck / before the upload, that's just broken).

AbdullahiFatola commented 1 month ago

Ok now I understand. A colleague in our team collected the data manually from this Goldbeck website into the Excel sheet. So we can fix the data internally according to the Information on the website.

AbdullahiFatola commented 1 month ago

How would you suggest to fix this? I tried just now to input 24:00:00 to replace 1900-01-01 00:00:00 in the excel file but it keeps formatting it to 1900-01-01 00:00:00

For closed would it be better to leave the cell empty?