search

Parker147 / Legends-Viewer

Recreates Dwarf Fortress' Legends Mode from exported files.
GNU General Public License v3.0
62 stars 12 forks source link

Added XML repair functionality to fix #14 #16

Closed JyeGuru closed 10 years ago

PeridexisErrant commented 10 years ago

The appveyor build seems to have included the 7z libraries and the readme... but not the Legends Viewer executable.

JyeGuru commented 10 years ago

Not sure how the AppVeyor settings were set up for Parker147's account, but it was outputting ok on mine (using a powershell script). I have added 'appveyor.yml' config file that will ensure AppVeyor builds and outputs it the same. Not saying these are the best settings - just that they work - happy for them to be changed.

In addition to the normal executable, I specifically added a zip output to the PS script, this adds all the files that are found in the DFFD download of LegendsViewer (the DLLs, exe, readme) rather than including everything (eg: the PDB file).

Parker147 commented 10 years ago

Yeah I played around with AppVeyor since I saw that you were using it and it looked nice, but didn't take the time to figure out how I could make it package all the build artifacts for me. That yml is a good addition.

JyeGuru commented 10 years ago

With regards to the function - I split it away from the main handing so it can be modified/improved if any other common XML issues come up. I tried my code on the largest export I had at hand (~450Mb uncompressed) and it didn't seem to have a significant impact on the load time, however this was only a basic test using a couple of PCs I have access to.

Give me a few and I'll move the try/catch around the new World() bit.

Parker147 commented 10 years ago

Merged a86a81c014b60d527fa24fddf67e2b99cd7e8831, 16f5e932b42a4cf7c7080f260827a4e004858532