ParkerICI / premessa

R package for pre-processing of mass and flow cytometry data
GNU General Public License v3.0
42 stars 24 forks source link

Option to turn off behavior of concatenate_fcs_files to copy $PnN name to $PnS of output file if $PnS of input fcs file is blank. #48

Closed kstoltz1 closed 1 year ago

kstoltz1 commented 1 year ago

Hi there,

Just a minor enhancement recommendation with how keywords are assigned to make it more compatible with immediately viewing in FlowJo.

Right now, when running concatenate_fcs_files, if the $PnS short name is missing in the fcs files being concatenated, the function automatically copies the $PnN name to the $PnS short name of the output file. When you load the newly concatenated fcs files into FlowJo alongside other original fcs files, this causes flowjo to recognize them as alternative parameters (since some now have a $PnS short name, and some do not). Because of this, modifications to the axis (changing to biex, log, etc) are not properly copied across a group, as shown in the attached screenshot. If a $PnS short name existed for a parameter in the input fcs file(s), these compatibility issues do not arise.

While I'm sure I can remove the $PnS names from the concatenated files, having the option to not copy the $PnN name to blank $PnS spaces in the first place would be nice too!

Screen Shot 2022-10-27 at 9 44 41 PM