search

ParkingReformNetwork / reform-map

A map of where parking reforms have happened.
https://parkingreform.org/mandates-map/
MIT License
6 stars 8 forks source link

Cities without citations fail to create city details page #356

Closed Eric-Arellano closed 3 months ago

Eric-Arellano commented 3 months ago

Cities without citations aren't having their details page created, like Crete NE, but we link to them so 404. Two possible solutions:

  1. Create the page still, and it won't have citations. The page won't have any new information compared to the scorecard, outside of the reporter
  2. Don't create the page & remove the link from CSV and scorecard

When fixing, enable this test:

https://github.com/ParkingReformNetwork/reform-map/blob/631c9d6ae6864579bf082a5ae4bfdcb75eda1317/tests/scripts/updateCityDetail.test.ts#L159-L171

Eric-Arellano commented 3 months ago

We decided that this is a data entry error. Every city should have a citation. We're going to fix these 3 cities:

Alexandria_VA
Crete_NE
LowerMacungieTownship_PA

Then we can enable the test safely.

Eric-Arellano commented 3 months ago

Fixed by https://github.com/ParkingReformNetwork/reform-map/pull/362. The new test means we won't regress.