Parnassius / cerbottana

GNU General Public License v3.0
1 stars 5 forks source link

Return error messages when a tour can't be created #150

Open f0ffee opened 3 years ago

f0ffee commented 3 years ago

Sometimes, when trying to create a tour with a bot command, nothing will happen.

It would be nice if there was some output explaining why the tour can't be created, for example because the server is restarting soon, or because there's another game in progress in the room.

Parnassius commented 3 years ago

Errors like this are sent with an |error| protocol message (|error|You cannot have a tournament until the current room activity is over: [Gen 3] Random Battle tournament).

These are the search results for |error| on the ps server code:

So, if we pass every |error| message we receive directly into the chatroom we solve this and similar problems, but we risk sending some (many?) messages we should probably not send. We can't really whitelist some specific messages (like You cannot have a tournament until the current room activity is over...), because sometimes they are translated

palt0 commented 3 years ago

Yeah this is something I wanted to address when we have a structure that supports parsing messages that are received shortly after a cerbottana command has been executed, to reduce false positives.