Add command to force join/leave a room

[f0ffee]

Scope: bot admins, + maybe room owners of rooms the bot is already in to make it leave?

[Parnassius]

it could probably also listen to /invite i'm not sure about .leave (or something like that) for room owners, because on the next bot/server restart it would join there once again. EDIT: and we should check what happens when it's invited in a battle

[palt0]

Summing up:

• What is the correct permission level for these commands? I got told that joining/leaving a room shouldn't be persistent to bot restart, so the main innovation would be joining temporary rooms such as groupchats. Considering that there are only 3 bot administrators currently, it might make sense to enable the botjoin command for global voices too.
• Do we want to support joining battle rooms? All of the room activity commands (creating tours, minigames, etc.) would fail silently in battle rooms, as of now.
• We could maybe listen to /invite alongside (or instead of) having a botjoin command.
• Regarding the botleave command, bot administrators should be able to use it for any room as a safety measure, but we could disable it for everyone else if the room is joined by cerbottana at autostart.

I created a draft branch some days ago and would like some feedback/confirmation on these points. On a side note, I improved the base logic that handles joining rooms and added a handler for |deinit|.

[Parnassius]

• What is the correct permission level for these commands? I got told that joining/leaving a room shouldn't be persistent to bot restart, so the main innovation would be joining temporary rooms such as groupchats. Considering that there are only 3 bot administrators currently, it might make sense to enable the botjoin command for global voices too.

Ideally I would do something like this:

• Bot administrators can do anything;
• Global voices (or global drivers, i'm not sure) can make it join everywhere;
• Room owners (or roommods) can make it join in their room and make it leave;
• Same for groupchat hosts;
• Same for players in their battle rooms.

So, we have these problems:

• How do we get players from a battle id? We could do /cmd userdetails, but that doesn't work for private battles.
• Groupchat and subrooms ids cannot be distinguished: in groupchat-foo-bar, foo can be both the user who created the groupchat, or the base room (bar is an arbitrary string).
• We cannot check room auth for private/hidden rooms. For public rooms we have to send something like /roomauth (i'm not sure if there's a more bot-friendly command), and wait for a response. Waiting for a response from inside a command is something we haven't done yet.

• Do we want to support joining battle rooms? All of the room activity commands (creating tours, minigames, etc.) would fail silently in battle rooms, as of now.

I'd say yes, eventually adding an additional parameter to command_wrapper.

• We could maybe listen to /invite alongside (or instead of) having a botjoin command.

Absolutely, if that's not too complicated (i have no idea how /invite is handled protocol-wise).

• Regarding the botleave command, bot administrators should be able to use it for any room as a safety measure, but we could disable it for everyone else if the room is joined by cerbottana at autostart.

I agree

I created a draft branch some days ago and would like some feedback/confirmation on these points. On a side note, I improved the base logic that handles joining rooms and added a handler for |deinit|.

I had a quick look and it seems good, i'll check more thoroughly in the next few days.