search

Parnassius / cerbottana

GNU General Public License v3.0
1 stars 5 forks source link

CAP Pokémon are not shown in `.sprite` #469

Closed f0ffee closed 2 years ago

f0ffee commented 2 years ago

CAP Pokémon are not considered when using the .sprite command. The bot will output an error of "Pokémon not found".

I'm not sure if they should be considered for .randsprite, but it definitely should be allowed to display their sprites when called individually.

f0ffee commented 2 years ago

My bad; CAP Pokémon are shown, it's just that not all CAP have a 3d model in http://play.pokemonshowdown.com/sprites/ani/.

For example, Arghonaut has a gen4 static sprite, and no animated model, so .sprite arghonaut, gen4 works, while .sprite arghonaut doesn't.

My suggestion then becomes, if it's feasible, to look into other folders before giving the error of "not found".

Parnassius commented 2 years ago

Ugh, this is not as trivial as I had hoped it would be. Basically, this is the piece of code in the pokemon showdown client responsible for choosing between an animated gif and a static png, where animationData refers to this file. Sadly we can't just build it and include it as a json alongside pokedex.json and aliases.json, because the build script requires the sprites to be there (obviously). I'll need to think about it, the easy (although not really clean) way out would obviously be to use the /gen5/ folder as a fallback when a sprite is not found in /ani/ (or /gen5-ani/), but I'd like to try to use https://play.pokemonshowdown.com/data/pokedex-mini.js (and https://play.pokemonshowdown.com/data/pokedex-mini-bw.js) first.