search

Parsely / parsely-android

The official Parse.ly Android toolkit -- for instrumenting your apps with Parse.ly
https://docs.parse.ly/android-sdk/
Other
6 stars 6 forks source link

Add optional `pageType` parameter to `ParselyMetadata` class in Android SDK #102

Closed MartinAkram closed 10 months ago

MartinAkram commented 10 months ago

⁉️ What ⁉️

This PR adds a new optional parameter, pageType, to the ParselyMetadata class in the Android SDK. This is being done in response to a client question/request (see linked issue below).

Companion iOS SDK PR: https://github.com/Parsely/AnalyticsSDK-iOS/pull/90

✔️ TODOs ✔️

wzieba commented 10 months ago

hi @MartinAkram ! Thanks for preparing the PR 👍

Presently, the main branch is under a set of changes (internal: pd3OIC-1tL-p2) and getting ready for a new major release. But I think this PR should not wait for the next major release, but rather land in 3.2.0 (current release is 3.1.1).

I've just prepared release/3.2.0 branch for you. It'd be great if you could rebase on it, instead of the main. Unfortunately It'll affect the code in the PR highly - e.g. ParselyMetadata is written in Java there. Sorry for that!

MartinAkram commented 10 months ago

Absolutely will do, @wzieba! Thanks so much

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (release/3.2.0@644cf41). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/3.2.0 #102 +/- ## ================================================ Coverage ? 72.04% ================================================ Files ? 18 Lines ? 372 Branches ? 53 ================================================ Hits ? 268 Misses ? 92 Partials ? 12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.