search

Parsely / parsely-android

The official Parse.ly Android toolkit -- for instrumenting your apps with Parse.ly
https://docs.parse.ly/android-sdk/
Other
6 stars 6 forks source link

Add UUID to each pageview event #74

Closed wzieba closed 1 year ago

wzieba commented 1 year ago

Closes: #28

Description

This PR is a twin of #73 for pageview and heartbeat events. It adds a new, internal field lastPageviewUuid. See internal discussion about necessity of it: p1696417656257339-slack-C0533SEJ82H

Test

  1. Install example app, open logcat
  2. Tap on Track Url
  3. Tap on Start Engagement
  4. Wait 30 seconds until you see [Parsely] POST Data {"events": (...) log. Copy the JSON part.
  5. Wait another 30 seconds until another [Parsely] POST Data {"events": (...) log, copy it as well.
  6. Check the copied logs:
    • there should be one "action": "pageview" event, rest of them should be "action": "heartbeat"
    • every event from both logs should have "pvid" field with the same value

New payload

Click Screenshot 2023-10-05 at 18 34 23
wzieba commented 1 year ago

Let's deal with https://github.com/Parsely/parsely-android/pull/73#discussion_r1348559473 here and remove it before merging this PR to master.

Thanks for being vigilant! Addressed in 61c3db3