search

Parsely / parsely-android

The official Parse.ly Android toolkit -- for instrumenting your apps with Parse.ly
https://docs.parse.ly/android-sdk/
Other
6 stars 6 forks source link

Extract building logic to EventsBuilder. Add unit tests for it. #79

Closed wzieba closed 1 year ago

wzieba commented 1 year ago

Description

This PR extracts logic of building events (pixels) and covers it with unit tests. It doesn't introduce any change in terms of how SDK works.

Tests

No need - review and CI check should be enough.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (e33285b) 0.00% compared to head (5394212) 20.44%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #79 +/- ## ========================================== + Coverage 0.00% 20.44% +20.44% ========================================== Files 4 5 +1 Lines 358 362 +4 Branches 58 58 ========================================== + Hits 0 74 +74 + Misses 358 278 -80 - Partials 0 10 +10 ``` | [Files](https://app.codecov.io/gh/Parsely/parsely-android/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Parsely) | Coverage Δ | | |---|---|---| | [...ava/com/parsely/parselyandroid/ParselyTracker.java](https://app.codecov.io/gh/Parsely/parsely-android/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Parsely#diff-cGFyc2VseS9zcmMvbWFpbi9qYXZhL2NvbS9wYXJzZWx5L3BhcnNlbHlhbmRyb2lkL1BhcnNlbHlUcmFja2VyLmphdmE=) | `0.86% <0.00%> (+0.86%)` | :arrow_up: | | [...java/com/parsely/parselyandroid/EventsBuilder.java](https://app.codecov.io/gh/Parsely/parsely-android/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Parsely#diff-cGFyc2VseS9zcmMvbWFpbi9qYXZhL2NvbS9wYXJzZWx5L3BhcnNlbHlhbmRyb2lkL0V2ZW50c0J1aWxkZXIuamF2YQ==) | `89.39% <89.39%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/Parsely/parsely-android/pull/79/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Parsely)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.