Parsely / parsely-android

The official Parse.ly Android toolkit -- for instrumenting your apps with Parse.ly
https://docs.parse.ly/android-sdk/
Other
6 stars 6 forks source link

Extract `QueueManager` and local storage related code. Cover with unit tests. #87

Closed wzieba closed 1 year ago

wzieba commented 1 year ago

Description

This PR extracts logic of QueueManager and extracts local storage related code, encapsulating it to LocalStorageRepository class.

It doesn't do anything related to threading model, so it's safe to merge this to main. After merge, I'll back port it to coroutines branch.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (fcb6d7c) 44.38% compared to head (1b8ffca) 51.63%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #87 +/- ## ========================================== + Coverage 44.38% 51.63% +7.24% ========================================== Files 8 10 +2 Lines 365 368 +3 Branches 56 55 -1 ========================================== + Hits 162 190 +28 + Misses 189 165 -24 + Partials 14 13 -1 ``` | [Files](https://app.codecov.io/gh/Parsely/parsely-android/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Parsely) | Coverage Ξ” | | |---|---|---| | [...in/java/com/parsely/parselyandroid/QueueManager.kt](https://app.codecov.io/gh/Parsely/parsely-android/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Parsely#diff-cGFyc2VseS9zcmMvbWFpbi9qYXZhL2NvbS9wYXJzZWx5L3BhcnNlbHlhbmRyb2lkL1F1ZXVlTWFuYWdlci5rdA==) | `100.00% <100.00%> (ΓΈ)` | | | [...ava/com/parsely/parselyandroid/ParselyTracker.java](https://app.codecov.io/gh/Parsely/parsely-android/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Parsely#diff-cGFyc2VseS9zcmMvbWFpbi9qYXZhL2NvbS9wYXJzZWx5L3BhcnNlbHlhbmRyb2lkL1BhcnNlbHlUcmFja2VyLmphdmE=) | `11.48% <25.00%> (-0.41%)` | :arrow_down: | | [...m/parsely/parselyandroid/LocalStorageRepository.kt](https://app.codecov.io/gh/Parsely/parsely-android/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Parsely#diff-cGFyc2VseS9zcmMvbWFpbi9qYXZhL2NvbS9wYXJzZWx5L3BhcnNlbHlhbmRyb2lkL0xvY2FsU3RvcmFnZVJlcG9zaXRvcnkua3Q=) | `75.86% <75.86%> (ΓΈ)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wzieba commented 1 year ago

Thanks for the review @ParaskP7 ! I'll proceed with the merge as I think we discussed or addressed every comment.

ParaskP7 commented 1 year ago

Great, thanks for the extra commit and answering my comments @wzieba , LGTM! πŸ™‡ 🌟 πŸš€