Closed wzieba closed 1 year ago
Attention: 13 lines
in your changes are missing coverage. Please review.
Comparison is base (
fcb6d7c
) 44.38% compared to head (1b8ffca
) 51.63%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the review @ParaskP7 ! I'll proceed with the merge as I think we discussed or addressed every comment.
Great, thanks for the extra commit and answering my comments @wzieba , LGTM! π π π
Description
This PR extracts logic of
QueueManager
and extracts local storage related code, encapsulating it toLocalStorageRepository
class.It doesn't do anything related to threading model, so it's safe to merge this to
main
. After merge, I'll back port it tocoroutines
branch.