search

Parsely / parsely-android

The official Parse.ly Android toolkit -- for instrumenting your apps with Parse.ly
https://docs.parse.ly/android-sdk/
Other
6 stars 6 forks source link

Migrate `ParselyMetadata` and `ParselyVideoMetadata` to Kotlin. Improve API. #96

Closed wzieba closed 11 months ago

wzieba commented 1 year ago

Description

This PR migrates ParselyMetadata and ParselyVideoMetadata to Kotlin and improves its API so it's easier to use - especially for clients, which use Kotlin.

Tests

There's no need to manually test this change. Unit tests should be fine.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (ee8614e) 68.24% compared to head (67a755b) 70.52%.

Files Patch % Lines
...com/parsely/parselyandroid/ParselyVideoMetadata.kt 27.27% 6 Missing and 2 partials :warning:
...java/com/parsely/parselyandroid/ParselyMetadata.kt 87.50% 0 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #96 +/- ## ========================================== + Coverage 68.24% 70.52% +2.27% ========================================== Files 16 16 Lines 359 363 +4 Branches 52 53 +1 ========================================== + Hits 245 256 +11 + Misses 97 92 -5 + Partials 17 15 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.