coderabbitai[bot]
commented
1 month ago Walkthrough
## Walkthrough The recent changes introduce several refinements to the feature-enabling logic within the `ContentHelperFeature` class. They modify how global and feature filters are applied by first checking if the filter names are non-empty before applying them. Additionally, the `get_feature_filter_name` method in the `ClassSmartLinking` class was updated to return an empty string directly, rather than constructing a non-useful return value. ## Changes | File Path | Change Summary | |------------------------------------------------|---------------------------------------------------------------------------------------------| | `src/content-helper/common/class-content-helper-feature.php` | Initialized `$global` and `$feature` to `null` and added conditions to check filter names before applying them. | | `src/content-helper/editor-sidebar/smart-linking/class-smart-linking.php` | Modified `get_feature_filter_name` to return an empty string instead of constructing one with a global filter name. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant Client participant ContentHelperFeature Client->>ContentHelperFeature: Call can_enable_feature() ContentHelperFeature->>ContentHelperFeature: Initialize $global and $feature to null ContentHelperFeature->>ContentHelperFeature: Check if global filter name is non-empty alt Global filter name non-empty ContentHelperFeature->>ContentHelperFeature: Apply global filter end ContentHelperFeature->>ContentHelperFeature: Check if feature filter name is non-empty alt Feature filter name non-empty ContentHelperFeature->>ContentHelperFeature: Apply feature filter end ContentHelperFeature->>Client: Return boolean result ```Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Description
This PR removes the feature filter -
wp_parsely_enable_content_helper_smart_linking- from the Smart Linking feature. This filter was only disabling the Smart Linking on the server-side, and therefore the UI was still available.Since enabling and disabling individual features is now supported in the settings page, this filter is not really required, as it never really worked correctly.
Motivation and context
Improved codebase by avoiding having unused/non-functional filters available.
How has this been tested?
Tested manually.
Summary by CodeRabbit