Parsely / wp-parsely

The official WordPress plugin for Parse.ly - makes it a snap to add the required tracking code to enable Parse.ly on your WordPress site.
https://wordpress.org/plugins/wp-parsely/
GNU General Public License v2.0
63 stars 32 forks source link

Fix deprecation warnings in the browser console in WordPress 6.6 #2668

Closed vaurdan closed 1 month ago

vaurdan commented 1 month ago

Description

As reported in #2667, on WordPress >= 6.6, the plugin is generating a few deprecation warnings. This is due to an unification of the extensibility APIs in 6.6, where some of the components we use are being moved from @wordpress/edit-post to @wordpress/editor.

The @wordpress/editor type definition from @types/wordpress__editor still does not account for these changes, so it required some creativity to workaround this warning. Although, in the near future it will updated, as there's already a PR open on that repository to implement these new changes.

However, the solution I came up for this - a wrapper for the components - might still be necessary even after that PR is merged, since I'm not sure that the components that have been moved to @wordpress/editor will work on WordPress older than 6.6.

Motivation and context

How has this been tested?

Tested locally in three different WordPress versions (6.6, 6.5, and 6.4), and validated that the fallback code works on older WP versions, and the new code works on 6.6.

Summary by CodeRabbit

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago
Walkthrough ## Walkthrough The changes primarily involve the creation of a TypeScript wrapper for Gutenberg components to address deprecation warnings introduced in WordPress 6.6. This wrapper dynamically imports components like `PluginDocumentSettingPanel` and `PluginSidebar` based on the environment, enhancing type safety and compatibility. Additionally, the modules that utilize these components have been updated to source them from the new wrapper, ensuring alignment with the latest WordPress structure and reducing potential TypeScript errors. ## Changes | Files | Change Summary | |-------------------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------| | `src/@types/gutenberg/wrapper.ts` | Introduced a TypeScript wrapper for Gutenberg components to handle deprecation warnings and dynamic imports based on the WordPress environment. | | `src/content-helper/editor-sidebar/editor-sidebar.tsx`
`src/content-helper/excerpt-generator/components/excerpt-panel.tsx` | Updated import statements for `PluginSidebar` and `PluginDocumentSettingPanel` to use the new wrapper, improving type safety and compatibility. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant Editor as Editor Component participant Wrapper as Gutenberg Wrapper participant Plugin as PluginSidebar/PluginDocumentSettingPanel Editor->>Wrapper: Import PluginSidebar/PluginDocumentSettingPanel activate Wrapper Wrapper->>Plugin: Check wp object alt wp object defined Wrapper->>Plugin: Import from wp.editor else wp object not defined Wrapper->>Plugin: Fallback import end deactivate Wrapper Editor->>Plugin: Use PluginSidebar/PluginDocumentSettingPanel ``` ## Assessment against linked issues | Objective | Addressed | Explanation | |----------------------------------------------------------|-----------|--------------------------------------------------| | Address deprecation warnings related to `PluginSidebar` and `PluginDocumentSettingPanel` (##2667) | ✅ | | | Ensure compatibility with different WordPress versions (##2667) | ✅ | | | Refactor import paths for improved type safety (##2667) | ✅ | |

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.