Parsifal-M / backstage-open-feedback

Feedback Plugin for Backstage
Apache License 2.0
13 stars 3 forks source link

Add Floating Feedback Button and Customizable Page Titles #49

Closed Baicheng-MiQ closed 3 months ago

Baicheng-MiQ commented 3 months ago

What type of PR is this?

Please check the category that applies:

Description

This pull request introduces two main enhancements to the OpenFeedback plugin:

  1. Floating Feedback Button:

    • Added the ability to render the feedback button as a floating action button (FAB) anywhere on the page. This is customizable using the floating prop and can be positioned with inline styles.
    • Updated Root.tsx to demonstrate the floating button implementation with a feedback icon.
  2. Customizable Page Titles and Subtitles:

    • Modified the OpenFeedbackPage component to allow passing custom titles and subtitles via props. This enables more flexibility when integrating the feedback page into different sections of the Backstage app.
    • Included unit tests to verify that the custom title and subtitle are correctly rendered.

Related Issues

(No specific issues linked)

Testing

Parsifal-M commented 3 months ago

Hey! πŸ‘‹

Some cool stuff in here! πŸš€

Thanks a lot!

Will take a look πŸ‘€

Baicheng-MiQ commented 3 months ago

added changes from https://github.com/Parsifal-M/backstage-open-feedback/pull/48#issuecomment-2265308474

Parsifal-M commented 3 months ago

added changes from #48 (comment)

Thanks a lot!

I have to run for the day now 😒

Will try give it a proper review later today/weekend and get back to you!

Thanks again! πŸš€

Parsifal-M commented 3 months ago

LGTM!

Well Done! Awesome stuff πŸš€

Will try set some time aside this week to release this πŸ˜„

Thanks again!

Baicheng-MiQ commented 3 months ago

Brilliant!! Happy to help! Thank you so much for the review! πŸ₯‡