ParsimonyGit / shipstation_integration

Other
14 stars 24 forks source link

fix: remove whitespace from customer before saving #82

Closed Alchez closed 1 year ago

Alchez commented 1 year ago

A string like ' First Last' would create the following traceback if 'First Last' already exists:

  File "frappe/utils/background_jobs.py", line 144, in execute_job
    method(**kwargs)
  File "shipstation_integration/orders.py", line 104, in list_orders
    create_erpnext_order(order, store)
  File "shipstation_integration/orders.py", line 170, in create_erpnext_order
    customer = create_customer(order)
  File "shipstation_integration/customer.py", line 156, in create_customer
    cust.save()
  File "frappe/model/document.py", line 312, in save
    return self._save(*args, **kwargs)
  File "frappe/model/document.py", line 334, in _save
    return self.insert()
  File "frappe/model/document.py", line 278, in insert
    raise e
  File "frappe/model/document.py", line 275, in insert
    self.db_insert()
  File "frappe/model/base_document.py", line 436, in db_insert
    raise frappe.DuplicateEntryError(self.doctype, self.name, e)
commit-lint[bot] commented 1 year ago

Bug Fixes

Contributors

Alchez

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR